rewrite graph struct to be 200 times faster#3882
Merged
near-bulldozer[bot] merged 54 commits intomasterfrom Feb 4, 2021
Merged
rewrite graph struct to be 200 times faster#3882near-bulldozer[bot] merged 54 commits intomasterfrom
near-bulldozer[bot] merged 54 commits intomasterfrom
Conversation
matklad
reviewed
Feb 2, 2021
pmnoxx
force-pushed
the
piotr-rewrite-graph
branch
2 times, most recently
from
efaa44b to
2888a01
Compare
pmnoxx
changed the title
matklad
reviewed
Feb 2, 2021
pmnoxx
force-pushed
the
piotr-rewrite-graph
branch
3 times, most recently
from
2921ebd to
4a2c741
Compare
pmnoxx
force-pushed
the
piotr-rewrite-graph
branch
from
7a63251 to
e704db0
Compare
pmnoxx
force-pushed
the
piotr-rewrite-graph
branch
from
0696882 to
b022a42
Compare
pmnoxx
force-pushed
the
piotr-rewrite-graph
branch
5 times, most recently
from
d504147 to
928af46
Compare
pmnoxx
changed the title
matklad
reviewed
Feb 3, 2021
Contributor
matklad
left a comment
matklad
left a comment
There was a problem hiding this comment.
Mostly nits, but total_active_edges seems like it might affect correctness.
Also, 100X perf improvement is nice :D
Also, I am wondering, does it make sense to try petgraph here? Although I myself also actually prefer to code simple graph routines myself.
pmnoxx
force-pushed
the
piotr-rewrite-graph
branch
from
0029d8c to
aa5b63f
Compare
bowenwang1996
approved these changes
Feb 4, 2021
Collaborator
bowenwang1996
left a comment
bowenwang1996
left a comment
There was a problem hiding this comment.
looks good to me. @mfornet can you also review?
bowenwang1996
pushed a commit
that referenced
this pull request
Feb 18, 2021
It looks like it's possible to rewrite graph class to be 200 times faster. Do we really need to move computation to another thread?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like it's possible to rewrite graph class to be 200 times faster. Do we really need to move computation to another thread?